Skip to content

fix: skip authentication for non-interactive commands#402

Merged
thde merged 2 commits into
mainfrom
thde/skip-auth
May 15, 2026
Merged

fix: skip authentication for non-interactive commands#402
thde merged 2 commits into
mainfrom
thde/skip-auth

Conversation

@thde
Copy link
Copy Markdown
Member

@thde thde commented May 13, 2026

nctl --help and nctl --version unnecessarily triggered API authentication.

The predictor client for shell completion was created eagerly on every invocation, even when completions weren't being requested. Additionally, --help/--version flags weren't recognized as commands that don't need an API client.

Changes

  • Gate predictor client creation on COMP_LINE: The API client is only created when the shell is actually requesting completions.
  • Skip API client for --help, -h, and --version flags anywhere in the args.

@thde thde merged commit 6a00642 into main May 15, 2026
3 checks passed
@thde thde deleted the thde/skip-auth branch May 15, 2026 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants